Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1120 replace deprecated numbered by sectnums v2.5.x #1127

Conversation

robertpanzer
Copy link
Member

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

This PR cherry picks #1124 into the v2.5.x branch.

@abelsromero
Copy link
Member

I did not even realize v2.5.x was being maintained and comparing the branches I see some changes that
seems to me should be ported (docs, gradle bump for instance).
What is the policy for porting changes from main?

@robertpanzer
Copy link
Member Author

I bumped the version on main to 3.0.0-SNAPSHOT a while ago after merging 2 breaking changes.
Everything that qualifies as a non-breaking change should also go into v2.5.x. (I am usually doing this right now)

@robertpanzer robertpanzer merged commit 53faf57 into asciidoctor:v2.5.x Oct 19, 2022
@robertpanzer robertpanzer deleted the issue-1120-replace-deprecated-numbered-by-sectnums-v2.5.x branch October 19, 2022 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants