Fix to allow extensions from non-"com." packages to be registered #251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for your collaboration, do you think it would be possible to provide a test that tests that a extension with package name starting with |
|
Sure, I"ll have a look where to put such test. |
Resolves asciidoctor#250, including test which fails without this fix
ktoso
force-pushed
the
fix-extension-importing-ktoso
branch
from
308f38d
to
be71324
Compare
|
Added test case (confirmed it fails without the fix) and squashed into one commit. Cheers! 🎄 |
|
Looks great! Thanks for the amazing 🎄 gift! |
lordofthejars
added a commit
that referenced
this pull request
Dec 24, 2014
Fix to allow extensions from non-"com." packages to be registered
|
Thank you so much, no worries about not including the test, it happens to me as well, for this reason I like to do(and receive) code reviews :) |
|
Changes Unknown when pulling be71324 on ktoso:fix-extension-importing-ktoso into * on asciidoctor:master*. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #250