Documents how safe mode works. #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Very well stated! My only suggestion is to change this from an admonition to a sidebar with the title "Safe mode and file system access" or something to that affect. An admonition is typically a brief note. Since there are several paragraphs of content, that's more like a sidebar. |
|
I think that github doesn't render correctly sidebar, at least in preview the sidebar style is not correctly rendered, for this reason I think I am going to change to a subsection. |
resolves asciidoctor#260 by adding a subsection about safe mode.
lordofthejars
added a commit
that referenced
this pull request
Dec 30, 2014
resolves #263 Documents how safe mode works
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documents how safe mode works. Resolves issue #260. Basically we have added the info about what is the default mode in API mode, why you should consider using
SAFEsafe mode and we add a link to Asciidoctor document where safe modes are explained.