Add Cell.getRawText() and ListItem.getRawText() to get unsubstituted … #517
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…text of table cells and list items.
This PR goes for the first point in #513 (comment) :
Add accessors to get the raw, unsubstituted text from a Table Cell or a ListItem.
The methods are each called
getRawText()
and they get the field@text
of the associated nodes instead of invoking the accessor methodtext
on the respective Ruby nodes, as these apply the substitutions.I am not really happy with the naming of the methods yet, as we have
String getContent()
andList<String> getLines()
on Blocks, butString getText()
andString getRawText()
on Cells and ListItems.But the thing that we're even able now to directly access members of the Ruby objects is already a great thing! This approach wouldn't work on 1.5.x without reimplementing all the functionality in the Java nodes in the same way as it works in the Ruby nodes.