Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds LogHandler documentation to README #670

Merged
merged 1 commit into from
Aug 9, 2018

Conversation

abelsromero
Copy link
Member

This PR adds a small documentation to explain how to register custom LogHandlers.

This is WIP and before merge I'd like to understand a couple of things I found in my tests in order to document them properly.

  • paths in the Cursor are absolute always, I tried with relative Files and Strings. Is that expected?
  • Some names are confusing to me: check the docs for the use of cursor.path, cursor.file and sourceFilename. Specially the latests. Is that also normal? If sourceFilename is always <script>, does it make sense to expose it?

@abelsromero
Copy link
Member Author

Java 7 is failing, I wonder if due to lack of TSL 1.2 support.
The questions is, should we keep support for 7?

@robertpanzer
Copy link
Member

Thanks for this awesome contribution!
With regards to the properties of the Cursor I am also unsure how to fully define them.

Regarding support for Java 7, I would like to keep at least that one for AsciidoctorJ 1.5.x even though the support from the CI seems to be lacking.
We already kicked out Java 6 with a minor release.
But I would be fine to disable the CI build for Java 7 if it is no longer working.

@abelsromero
Copy link
Member Author

With regards to the properties of the Cursor I am also unsure how to fully define them.

OK then, if it's fine for you, we can merge.

I would like to keep at least that one for AsciidoctorJ 1.5.x

I can have a look at it. If the issue is what I think it's easy

@robertpanzer robertpanzer merged commit 8055c7d into asciidoctor:master Aug 9, 2018
@robertpanzer
Copy link
Member

🙌 Thanks! 🎉

@abelsromero abelsromero deleted the add_logHandler_docs branch December 23, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants