Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not merge command-line to string #836

Merged
merged 1 commit into from
Jul 25, 2019
Merged

fix: do not merge command-line to string #836

merged 1 commit into from
Jul 25, 2019

Conversation

Fiouz
Copy link
Contributor

@Fiouz Fiouz commented Jul 22, 2019

Fixes #817

@robertpanzer
Copy link
Member

Looks good to me, thanks!
The build on Appveyor failed, but that seemed to be a problem with fetching the Asciidoctor gems and you say that it is building on Windows.
We might want to further cleanup toAsciidoctorCommand() though.
I haven't looked into it yet, but there are some places where handling of the types is not really clean.

@robertpanzer robertpanzer merged commit 51ce7d9 into asciidoctor:master Jul 25, 2019
Fiouz added a commit to Fiouz/asciidoctorj that referenced this pull request Aug 5, 2019
@Fiouz
doc(changelog): asciidoctor#836 is not Windows-specific
c0046b0 
The issue can appear on any OS supporting white space in paths which
includes Linux and macOS.
robertpanzer added a commit that referenced this pull request Aug 5, 2019
@robertpanzer
Merge pull request #839 from Fiouz/update_changelog
bac3414 
doc(changelog): #836 is not Windows-specific
Fiouz pushed a commit to Fiouz/asciidoctorj that referenced this pull request Aug 9, 2019
@robertpanzer
Merge pull request asciidoctor#839 from Fiouz/update_changelog
1377556 
doc(changelog): asciidoctor#836 is not Windows-specific
Fiouz added a commit to Fiouz/asciidoctorj that referenced this pull request Aug 9, 2019
@Fiouz
Merge remote-tracking branch 'origin/master' into asciidoctorgh-747
70b8082 
* origin/master:
  doc(changelog): asciidoctor#836 is not Windows-specific
Fiouz added a commit to Fiouz/asciidoctorj that referenced this pull request Aug 9, 2019
@Fiouz
Merge remote-tracking branch 'origin/master' into asciidoctorgh-747
e8c7e72 
* origin/master:
  doc(changelog): asciidoctor#836 is not Windows-specific
@Fiouz Fiouz deleted the gh-817 branch August 10, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AsciidoctorUtils.toAsciidoctorCommand() signature not compatible with paths containing spaces
2 participants
@Fiouz @robertpanzer