Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update section about running on WildFly #848

Merged
merged 2 commits into from
Sep 25, 2019
Merged

Update section about running on WildFly #848

merged 2 commits into from
Sep 25, 2019

Conversation

anthonyvdotbe
Copy link
Contributor

  • update the JRuby dependency (this is required to make it work with WildFly 17.0.1, and matches the JRuby version that the current v2.1.0 depends upon)
  • rename "WildFly AS" to just "WildFly"

@anthonyvdotbe
Update section about running on WildFly
c0c9143 
* update the JRuby dependency (this is required to make it work with WildFly 17.0.1, and matches the JRuby version that the current v2.1.0 depends upon)
* rename "WildFly AS" to just "WildFly"
@robertpanzer
Copy link
Member

Thank you for your PR!
Could you please also update the version of JCommander in the README?
We are using 1.72 right now.

@anthonyvdotbe
Copy link
Contributor Author

You're welcome. I updated the version of JCommander as well.

@robertpanzer robertpanzer merged commit 058f86d into asciidoctor:master Sep 25, 2019
@robertpanzer
Copy link
Member

Thanks!

@anthonyvdotbe anthonyvdotbe deleted the patch-2 branch September 25, 2019 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anthonyvdotbe @robertpanzer