chore(OSGi): switch to biz.aQute.bnd plugin #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Native Gradle OSGi integration is deprecated in Gradle 5.x https://docs.gradle.org/5.0/release-notes.html#deprecated-osgi-plugin - Use OSGi annotations to lower manifest synchronization cost https://bnd.bndtools.org/chapters/230-manifest-annotations.html - Adjusted Export-Package for asciidoctorj-api: - 'org.asciidoctor.spi' removed as it seems an overlook of bc75314 - added org.asciidoctor.syntaxhighlighter as generation was reporting the following warning: warning: Export org.asciidoctor, has 1, private references [org.asciidoctor.syntaxhighlighter] (may have been an overlook of 3e9d47e) On a side note, the Bundle-SymbolicName conflict reported at asciidoctor#772 still exists.
|
I am not really that much into OSGi, so I have a hard time testing this. |
|
Thanks! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.gradle.org/5.0/release-notes.html#deprecated-osgi-plugin
https://bnd.bndtools.org/chapters/230-manifest-annotations.html
Export-Packagefor asciidoctorj-api:org.asciidoctor.spiremoved as it seems an overlook of bc75314org.asciidoctor.syntaxhighlighteras generation wasreporting the following warning:
warning: Export org.asciidoctor, has 1, private references [org.asciidoctor.syntaxhighlighter](may have been an overlook of 3e9d47e)
On a side note, the Bundle-SymbolicName conflict reported at #772 still
exists.