Add SpringBoot integration test to showcase cp configuration #994
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of change
Description
What is the goal of this pull request?
Fixes #976 adding a test to validate and showcase SpringBoot required configuration for a Gradle project.
How does it achieve that?
Add a new module
asciidoctorj-springboot-integration-test
that contains a spring-boot rest servicespringboot-app
to convert Asciidoc sources and a test that:springboot-app
is added as another module to the overall build and theassemble
task is set as dependency for theasciidoctorj-springboot-integration-test
test
.Are there any alternative ways to implement this?
Studied a version where
springboot-app
was a fully independent project and was build from the test using aProcess
, however:ProcessHelper
class) the build was executed with the default's OS javac. I suspect this still can happen when starting the service but should not be an issue in CI 🤞 .Are there any implications of this pull request? Anything a user must know?
On one side SpringBoot issues is a regular question and would be nice to add something users can find easily...on the other, I'd rather not add manual tasks or duplicate docs from other sources. Also having a note in the docs is no guarantee users will check docs since this the error message and cause of it is quite missleading.
Issue
If this PR fixes an open issue, please add a line of the form:
Fixes #Issue
#973 #820
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc