Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SpringBoot guide and update example #995

Merged

Conversation

abelsromero
Copy link
Member

@abelsromero abelsromero commented Feb 14, 2021

Thank you for opening a pull request and contributing to AsciidoctorJ!

Please take a bit of time giving some details about your pull request:

Kind of change

  • Bug fix
  • New non-breaking feature
  • New breaking feature
  • Documentation update
  • Build improvement

Description

What is the goal of this pull request?

Add guide to docs about SpringBoot quirks.

How does it achieve that?

Adds new page Running AsciidoctorJ with Spring Boot

Are there any alternative ways to implement this?

Not.

Are there any implications of this pull request? Anything a user must know?

Also updates the test. I run some extra tests and current versions does not require exclusion of jRuby.

Issue

If this PR fixes an open issue, please add a line of the form:

Fixes #Issue

Release notes

Please add a corresponding entry to the file CHANGELOG.adoc

@abelsromero
Copy link
Member Author

With this I think we can close #820 & #666.

@robertpanzer
Copy link
Member

Awesome, thank you!

@robertpanzer robertpanzer merged commit d1c438f into asciidoctor:master Feb 15, 2021
@abelsromero abelsromero deleted the docs/add-springboot-guide branch December 23, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants