Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade build to Antora 3.0.0-alpha.4 #63

Merged
merged 1 commit into from May 2, 2021

Conversation

mojavelinux
Copy link
Member

No description provided.

@mojavelinux
Copy link
Member Author

The AsciiDoc quick reference is impacted by this bug in Asciidoctor: asciidoctor/asciidoctor#4023

We could apply a workaround or wait until the next release of Asciidoctor/Asciidoctor.js is available.

@mojavelinux
Copy link
Member Author

mojavelinux commented Apr 16, 2021

We're also getting a new warning about a missing attribute reference in the content source for Asciidoctor EPUB3. This is either a regression in Asciidoctor 2, or Asciidoctor 2 is reporting a missing attribute where it didn't before.

Update: It looks like an unintended side effect of a fix. See asciidoctor/asciidoctor#4024

@mojavelinux
Copy link
Member Author

We're going to wait on Antora 3.0.0-alpha.4 to upgrade.

@mojavelinux mojavelinux changed the title upgrade build to Antora 3.0.0-alpha.3 upgrade build to Antora 3.0.0-alpha.4 May 2, 2021
@mojavelinux
Copy link
Member Author

The changes are now very minor. The impact is as follows:

  • Listing blocks with no style are promoted to a source block if the source-language is set (generally only affects listing blocks in the asciidoc component)
  • Space in mailto link is represented as + instead of %20
  • Normal substitutions are applied to cells in table header row if column has a (asciidoc) or l (literal) style
  • table-frame and table-grid attributes apply to nested tables
  • Remove extensions that backport Asciidoctor 2 features (collapsible block and global table frame and grid attributes)

@mojavelinux mojavelinux merged commit be15777 into asciidoctor:main May 2, 2021
@mojavelinux mojavelinux deleted the antora-3-alpha-3 branch May 2, 2021 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant