feat(usecase): ajaxappにdescriptionを追加 #684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@azu これだけ追加しておけばTOCは生成できるんですかね？ |
|
Deploy preview for js-primer ready! Built with commit 4b30e36 |
|
https://github.com/asciidwango/js-primer/blob/master/tools/generate-summary-1.js |
azu
reviewed
Mar 4, 2019
| @@ -1,5 +1,6 @@ | |||
| --- | |||
| author: laco | |||
| description: "XHRを使って取得したデータをもとにHTMLを組み立ててブラウザ上で表示します。" | |||
There was a problem hiding this comment.
XHRとXMLHttpRequestがぶれてるので、description的にはXMLHttpRequestで統一で良さそう
There was a problem hiding this comment.
descriptionはmeta descriptionにもなるので検索結果に出ることを意識しておくと良いです
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#676