Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key-press overlay #79, PR #167 update tentative #230

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

ludolpif
Copy link
Contributor

WIP for asciinema/discussions#152, UI cherry-picked from daonb PR #167 without the event handling code into current develop branch.

Let me know if it's help doing it this way.

I'm unsure about the correct way to make the input events hooking, even with recents updates for #222 and despite my reading of #167 (comment)

image

@ku1ik
Copy link
Contributor

ku1ik commented Sep 1, 2023

Hey, I haven't looked at this since it's a draft and therefore I thought it's not ready to be looked at. There are some conflicts, but I'll take care of that, no wories. Given you haven't pushed more since opening this PR I figure it's in a ready-to-review state, right?

@ludolpif
Copy link
Contributor Author

ludolpif commented Sep 6, 2023

Hey, I haven't looked at this since it's a draft and therefore I thought it's not ready to be looked at. There are some conflicts, but I'll take care of that, no worries. Given you haven't pushed more since opening this PR I figure it's in a ready-to-review state, right?

Hi, you're right. Thanks for pointing out that I leaved this PR out of my mind this summer. The project I may use this feature is delayed until a job switch but I hope work again on it in a reasonable delay.

If you have tips to clarify my mind about the following point :

I'm unsure about the correct way to make the input events hooking, even with recents updates for #222 and despite my reading of #167 (comment)

It may help me going farther. I am a bit lost about the targeted architecture you imagine at a global scope.

Thanks for all the fish,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants