Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow serving asciinema from other than / #365

Merged
merged 4 commits into from Nov 2, 2020
Merged

Allow serving asciinema from other than / #365

merged 4 commits into from Nov 2, 2020

Conversation

lyknode
Copy link
Contributor

@lyknode lyknode commented Nov 1, 2020

Fixes #296.

This is a set of patch to allow serving asciinema on other path than /.

It includes:

  • Fixing absolute links in the CSS
  • Fixing absolute routes in templates
  • Fixing absolute routes in controllers

I've tested with locally, including upload, play, registering and connection, all of which seem to work well.

ku1ik
ku1ik approved these changes Nov 2, 2020
View reviewed changes
Copy link
Contributor

@ku1ik ku1ik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This looks great 👌

@ku1ik ku1ik merged commit 077f90a into asciinema:develop Nov 2, 2020
@ku1ik
Copy link
Contributor

ku1ik commented Nov 2, 2020

I did a little bit of local as well and it seems to be working nicely.

@tengzl33t tengzl33t mentioned this pull request Nov 22, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ku1ik ku1ik ku1ik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Phoenix routing challenges with a subfolder deployment
2 participants
@lyknode @ku1ik