Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contao 4.9 compatibility #1

Closed
fritzmg opened this issue Jul 17, 2020 · 1 comment
Closed

Contao 4.9 compatibility #1

fritzmg opened this issue Jul 17, 2020 · 1 comment

Comments

@fritzmg
Copy link

fritzmg commented Jul 17, 2020

This extension breaks the search indexing in Contao 4.9, since it replaces the regular page type, which then causes the JSON-LD information for the front end to be missing. See contao/contao#1939

In order to fix it, you probably have to change

$this->createFooterScripts($objLayout);

to

$this->createFooterScripts($objLayout, $objPage);

if you still need to register your own page type.

It would be better if you didn't replace the page type. Why exactly do you need to do that?

@asconsulting
Copy link
Owner

The module dynamically replaces the template and loads JS based on what elements/modules are on the page. There was no hook that could perform the same functionality, and had the information my module needed passed to it so I was forced to override the base page class.

I have updated my module to closer match the 4.9 PageRegular Class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants