Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search not working #1939

Closed
rburch opened this issue Jul 16, 2020 · 12 comments
Closed

Search not working #1939

rburch opened this issue Jul 16, 2020 · 12 comments

Comments

@rburch
Copy link

rburch commented Jul 16, 2020

Affected version(s)
Contao 4.9.3 and 4.9.4

Description
I've done about 6 upgrades to Conato 4.9 and I've noticed that none of the searches work anymore. They seem to index when I use the crawler, but none of the pages set to being searchable seem to actually get indexed.

After running it I get:
indextl_search: 0 entries, 48 KiB
tl_search_index: 0 entries, 48 KiB

In the log for the pages I get:
Do not request because when the crawl URI was found, the "rel" attribute contained "nofollow".
and also
Forwarded to the search indexer. Did not index because of the following reason: No JSON-LD found.

These are all upgrades for Contao 4.4 where the search was working before the upgrade.

@aschempp
Copy link
Member

Did you adjust the front end template(s) (fe_page)?

@rburch
Copy link
Author

rburch commented Jul 16, 2020

I'm using the default fe_page. Do I have to add something to the template for the search to work?

@rburch
Copy link
Author

rburch commented Jul 16, 2020

Here's the log. Maybe that will help.
crawl_debug_log.zip

@ausi
Copy link
Member

ausi commented Jul 16, 2020

The JSON-LD information (from https://github.com/contao/contao/blob/4.9.4/core-bundle/src/Resources/contao/pages/PageRegular.php#L837 ) is missin on your pages.

Are you sure you did not remove the following line from your fe_page template? https://github.com/contao/contao/blob/4.9.4/core-bundle/src/Resources/contao/templates/frontend/fe_page.html5#L95

@rburch
Copy link
Author

rburch commented Jul 16, 2020

Yes, I'm sure. It's in there. It's the default template. I just turned mootools on in my page layout and turned on moo accordion to make sure. I'm not the only one who has had this issue I think. It's been on every site for me sense the search crawler switched. 6 or 7 sites.

https://community.contao.org/de/showthread.php?78311-Suchindex-baut-nicht-auf-No-Jason-ID-found-!

@rburch
Copy link
Author

rburch commented Jul 17, 2020

Did a fresh Contao 4.9.4 install and set up a few pages and I'm getting the same issue.
Forwarded to the search indexer. Did not index because of the following reason: No JSON-LD found.

@ausi
Copy link
Member

ausi commented Jul 17, 2020

Please add the following line here: https://github.com/contao/contao/blob/4.9.4/core-bundle/src/Resources/contao/pages/PageRegular.php#L845 and tell us what it outputs.

var_dump($strScripts, $meta);

@rburch
Copy link
Author

rburch commented Jul 17, 2020

string(24) "[[TL_JQUERY]][[TL_BODY]]" NULL
https://gsssi.brightcloudstudioserver.com/

@fritzmg
Copy link
Contributor

fritzmg commented Jul 17, 2020

Are you using a theme or extensions? If yes, which ones?

@fritzmg
Copy link
Contributor

fritzmg commented Jul 17, 2020

Ah, I already see the problem. You are using the following extension: https://github.com/asconsulting/zyppy_popup

This extension replaces Contao's own regular page type with a new page type - which in turn causes this information to be missing (may be amongst other things). This needs to be fixed in the extension.

@rburch
Copy link
Author

rburch commented Jul 17, 2020

Wow, thank you so much! I removed that extension and it seems to be working. That was a great help.

@Toflar Toflar closed this as completed Jul 20, 2020
@JNBG
Copy link

JNBG commented Nov 18, 2022

Noch ein Hinweis, für alle die hier nach dem 4.13er Upgrade mal drüber stolpern und bei denen auch das <?= $this->mootools ?> im fe_page.html5 Template steht.
Bei mir fehlte grade noch die Funktion <?= $this->jsonLdScripts ?> welche neben dem mootools noch exakt die json-ld daten ausgibt

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants