Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for embedding protobuf sources in outputs #207

Closed
ascopes opened this issue May 11, 2024 · 0 comments · Fixed by #218
Closed

Add support for embedding protobuf sources in outputs #207

ascopes opened this issue May 11, 2024 · 0 comments · Fixed by #218
Labels
documentation Improvements or additions to documentation new feature A new user-facing feature.
Milestone
v2.1.x

Comments

@ascopes
Copy link
Owner

ascopes commented May 11, 2024

We should add the option to include the input protobuf sources in the project outputs (as a resource).

This will enable users to generate JARs that can be reused elsewhere with this plugin.

Currently, the user has to deal with embedding these files manually by adding them as a project resource directory.
@ascopes ascopes added documentation Improvements or additions to documentation new feature A new user-facing feature. labels May 11, 2024
@ascopes ascopes added this to the v2.1.x milestone May 11, 2024
ascopes added a commit that referenced this issue May 13, 2024
@ascopes
GH-207: Implement ability to embed proto sources in output JAR
4f30ca6
ascopes added a commit that referenced this issue May 13, 2024
@ascopes
GH-207: Implement ability to embed proto sources in output JAR
8f448bf
@ascopes ascopes mentioned this issue May 13, 2024
Merged
ascopes added a commit that referenced this issue May 13, 2024
@ascopes
Merge pull request #218 from ascopes/feature/GH-207-embedding
94bc2ad 
GH-207: Implement ability to embed proto sources in output JAR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation Improvements or additions to documentation new feature A new user-facing feature.
Projects
None yet
Milestone
v2.1.x
Development

Successfully merging a pull request may close this issue.

GH-207: Implement ability to embed proto sources in output JAR ascopes/protobuf-maven-plugin
1 participant
@ascopes