Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-79: Handle special characters in shell scripts better #109

Merged
merged 5 commits into from
Mar 7, 2024
Merged

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Mar 7, 2024

  • Handle \r \n and \t in shell scripts.
  • Handle % in batch scripts.

Fixes GH-79.

- Handle \r \n and \t in shell scripts.
- Handle % in batch scripts.

Fixes GH-79.
@ascopes ascopes added the bug Something isn't working label Mar 7, 2024
@ascopes ascopes self-assigned this Mar 7, 2024
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.41%. Comparing base (313d79c) to head (ca2edf7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #109      +/-   ##
==========================================
+ Coverage   85.21%   85.41%   +0.21%     
==========================================
  Files          23       23              
  Lines         723      733      +10     
  Branches       49       49              
==========================================
+ Hits          616      626      +10     
  Misses         86       86              
  Partials       21       21              
Files Coverage Δ
...ub/ascopes/protobufmavenplugin/platform/Shlex.java 100.00% <100.00%> (ø)

@ascopes ascopes merged commit 3b8a61b into main Mar 7, 2024
12 checks passed
@ascopes ascopes deleted the bugfix/GH-79 branch March 7, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle special characters in Shlex better
1 participant