Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not treat backslashes in batch scripts as special characters #286

Merged
merged 1 commit into from
Jul 6, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Jul 6, 2024

This appears to be unnecessary and results in noisy command line strings when running on Windows.

@ascopes ascopes added the internal improvement Fixing things that are kind of rubbish label Jul 6, 2024
@ascopes ascopes added this to the v2.3.x milestone Jul 6, 2024
@ascopes ascopes self-assigned this Jul 6, 2024
Copy link

codecov bot commented Jul 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (b110e64) to head (8dd1507).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #286   +/-   ##
=======================================
  Coverage   87.49%   87.49%           
=======================================
  Files          35       35           
  Lines        1015     1015           
  Branches       74       74           
=======================================
  Hits          888      888           
  Misses         96       96           
  Partials       31       31           
Files Coverage Δ
...ithub/ascopes/protobufmavenplugin/utils/Shlex.java 100.00% <ø> (ø)

@ascopes ascopes force-pushed the task/do-not-escape-backslash-in-batch branch from a6d270b to 8dd1507 Compare July 6, 2024 10:51
@ascopes ascopes merged commit d83b797 into main Jul 6, 2024
14 checks passed
@ascopes ascopes deleted the task/do-not-escape-backslash-in-batch branch July 6, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal improvement Fixing things that are kind of rubbish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant