Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip execution if no sources are discovered #62

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Jan 12, 2024

Skip any execution if no sources are discovered, rather than erroring when protoc is called.

Skip any execution if no sources are discovered, rather than erroring when
protoc is called.
@ascopes ascopes added the bug Something isn't working label Jan 12, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6aa7034) 84.38% compared to head (117cd17) 83.85%.

Files Patch % Lines
...tobufmavenplugin/generate/SourceCodeGenerator.java 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #62      +/-   ##
==========================================
- Coverage   84.38%   83.85%   -0.54%     
==========================================
  Files          17       17              
  Lines         474      477       +3     
  Branches       34       35       +1     
==========================================
  Hits          400      400              
- Misses         57       59       +2     
- Partials       17       18       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ascopes ascopes merged commit d399c56 into main Jan 12, 2024
8 of 10 checks passed
@ascopes ascopes deleted the bugfix/skip-for-empty-sources branch January 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant