Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-86: Fix exception causes being omitted from Maven output #87

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

ascopes
Copy link
Owner

@ascopes ascopes commented Feb 4, 2024

Update exception handling to report causes correctly to Maven logs when running with mvn -e.

Fixes GH-86.

@ascopes ascopes added bug Something isn't working java labels Feb 4, 2024
@ascopes ascopes self-assigned this Feb 4, 2024
Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (fbff0d0) 86.85% compared to head (730fa6e) 86.30%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #87      +/-   ##
==========================================
- Coverage   86.85%   86.30%   -0.54%     
==========================================
  Files          21       21              
  Lines         631      635       +4     
  Branches       54       54              
==========================================
  Hits          548      548              
- Misses         58       62       +4     
  Partials       25       25              
Files Coverage Δ
...opes/protobufmavenplugin/AbstractGenerateMojo.java 59.65% <0.00%> (-2.16%) ⬇️
...rotobufmavenplugin/source/ProtoSourceResolver.java 72.73% <0.00%> (-2.74%) ⬇️

@ascopes ascopes merged commit bc90e85 into main Feb 4, 2024
9 of 11 checks passed
@ascopes ascopes deleted the bugfix/GH-86-missing-exception-causes branch February 4, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception causes are not reported to the Maven console correctly
1 participant