-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(qwik): don't externalise @unpic/core
dep
#254
Conversation
✅ Deploy Preview for unpic-svelte ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-solid ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-vue ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-qwik ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-webc ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-preact canceled.
|
✅ Deploy Preview for unpic-angular ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-docs canceled.
|
✅ Deploy Preview for unpic-next ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-lit ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for unpic-astro ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
🤖 I have created a release *beep* *boop* --- <details><summary>qwik: 0.0.20</summary> ## [0.0.20](qwik-v0.0.19...qwik-v0.0.20) (2023-06-19) ### Bug Fixes * **qwik:** don't externalise `@unpic/core` dep ([#254](#254)) ([089245b](089245b)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
I'm not sure why, but when installed with pnpm, rollup is unable to resolve the
@unpic/core
transitive dependency. This PR moves the package out of external deps, so that it is compiled into the bundle. Fixes #69