Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for cloudflare images without custom domain #131

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dawaltconley
Copy link

@dawaltconley dawaltconley commented May 23, 2024

Should fix #111

I wrote this pretty quick, fyi, as a patch for a project where I only need to support imagedelivery.net images.

Flagging the added filter here that removes empty transformation queries.

  const transformString = Object.entries(transformations)
    .filter(([key, value]) => Boolean(key) && value !== undefined)
    .map(([key, value]) => `${key}=${value}`)
    .join(",");

I added this because the current regex would pick up an image variant (e.g. /public) as a query and include it in the transform string (?public=undefined). But this change could potentially affect other cloudflare_image urls if I'm not understanding how their transformation queries work.

@dawaltconley dawaltconley changed the title add support for cloudflare images without custom domain feat: add support for cloudflare images without custom domain May 23, 2024
Copy link
Owner

@ascorbic ascorbic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks good to me, and the tests pass. It's blocked by a problem with the Supabase test site which I'll need to fix before merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can you support cloudflare-image without custom domain?
2 participants