-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support Astro _image endpoint #94
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey! Thanks for this. We just need a few things to get this ready to merge.
As well as the individual comments, framework transformers need to implement delegateUrl. This is needed so that if the user passes a URL with an href that matches another CDN, we use that instead of the local server. Take a look at the Next.js tests for examples.
Sure! I think the |
Just wanted to say thank you for your help reviewing this PR @ascorbic 👍 great suggestions |
I fixed those issues and squashed to a single commit 👍 |
Hi @ascorbic 👋 please let me know if there’s anything else I need to fix with this PR—thanks again for reviewing 👍 |
@ascorbic and @jlarmstrongiv are there any blockers for this PR? I found unpic-img has an astro component, and wanted to use it with the astro assets image endpoint in my project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you @ascorbic ! Your suggestions were very helpful 😄 |
Closes #93