Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditions and Out of Power priority's #2116

Open
Antorinia opened this issue Nov 13, 2023 · 2 comments
Open

Conditions and Out of Power priority's #2116

Antorinia opened this issue Nov 13, 2023 · 2 comments

Comments

@Antorinia
Copy link

Antorinia commented Nov 13, 2023

WoW Version

Retail

TellMeWhen Version

10.1.6

Describe the bug

i have this bug over a few years, tired of it :) so listen... (fix pls! <3)
when i have any condition on the spell or spell isnt ready with cooldown, i color this icon into "desaturate"
and it works good, until spell is out of power (no enough mana etc)
so my not ready or just any other condition overrides with "out of power" icon color

image

the problem is desaturated spell means "cant use" it yet, but when im out of mana spell goes back to original color (just with ~50% opacity)
should be just like this when on cd even if out of power

image

can you make it so conditions and "not ready" dont overrides with out of power color? because i have to make two icons for one spell to make it work good (one for not ready only, without anything else, and second one just usual when ready or out of mana etc)

second bug

image

i set my spell like this, so when its on cd i can see cd going and hide it at all when its just ready, but...
when i am out of range to my target i can see this spell icon again (and i dont want to see it without CD)

image

two bugs are pretty same problem just different opacity / color lines

Export Strings

^1^T^SShowTimer^B ^SType^Scooldown ^SConditions^T ^N1^T ^SType^SPTSINTAL ^SChecked^B ^SLevel^N1 ^SName^SRemove~`Corruption ^t^Sn^N1 ^t^SName^S2782 ^SShowTimerText^B ^SClockGCD^B ^SSettingsPerView^T ^Sicon^T ^STexts^T ^N2^S[Stacks:Hide(0,~`1)] ^t^t^t^SStates^T ^N2^T ^SColor^Sffffffffd ^SAlpha^N0.5 ^t^N3^T ^SColor^Sffff0000 ^t^t^SRangeCheck^B ^SEnabled^B ^SManaCheck^B ^t^N101600^S~`~| ^Sicon^^

^1^T^SShowTimer^B ^SType^Scooldown ^SConditions^T ^N1^T ^SType^SPTSINTAL ^SChecked^B ^SLevel^N1 ^SName^SSoothe ^t^Sn^N1 ^t^SName^S2908 ^SShowTimerText^B ^SClockGCD^B ^SSettingsPerView^T ^Sicon^T ^STexts^T ^N2^S[Stacks:Hide(0,~`1)] ^t^t^t^SStates^T ^N1^T ^SAlpha^N0 ^t^N2^T ^SColor^Sffffffffd ^SAlpha^N1 ^t^N3^T ^SColor^Sffff0000 ^t^t^SRangeCheck^B ^SEnabled^B ^SManaCheck^B ^t^N101600^S~`~| ^Sicon^^
@ascott18
Copy link
Owner

ascott18 commented Nov 18, 2023

I'm afraid I really don't understand why you'd want to check for power/range when a spell is on cooldown while also not wanting to see that information when the spell is off cooldown. Suppose its off cooldown and out of range - what's the point in not being able to see that?

I also don't quite understand the desire to have an icon show only when something is unusable, and not show when usable, but that part does indeed work. When a spell is out of range or out of power, it is unusable, and that takes priority.

I will agree that the order of the sliders in the UI is confusing if you think of them as being evaluated from top to bottom. I will reorder them so Out of Range/Power are above Ready/Not Ready. Maybe some confusion also stems from the use of the label "Ready" instead of "Usable".

ascott18 added a commit that referenced this issue Nov 18, 2023
…earer that they are based on total usability, not on/off cooldown (i.e. readiness) status. Also updated ordering to reflect top-to-bottom evaluation order
@Antorinia
Copy link
Author

Antorinia commented Nov 20, 2023

i mean when my spell isnt ready i want to see desaturated icon
but when spell inst ready AND out of mana... i see it as spell is out of mana color, not desaturated thats it
same with conditions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants