Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add flag to remove plugin if it's already installed #14

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

aabouzaid
Copy link
Collaborator

Change default behavior, and don't remove the plugin if it's already installed unless explicitly configured to avoid redownloading all versions of the plugin's app binary.

@aabouzaid aabouzaid added the enhancement New feature or request label Sep 4, 2023
@aabouzaid aabouzaid self-assigned this Sep 4, 2023
@aabouzaid aabouzaid requested a review from a team as a code owner September 4, 2023 21:41
@aabouzaid aabouzaid merged commit 1369b04 into main Sep 4, 2023
6 checks passed
@aabouzaid aabouzaid deleted the refactor-explicit-remove-in-add branch September 4, 2023 21:45
MPV added a commit to MPV/asdf-plugin-manager that referenced this pull request Sep 26, 2023
Given the bug in 1.0.0 (fixed in 1.1.0) where it removed all pre-existing plugins (and thus their installed versions of your tools), as per:
- asdf-community#14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

Successfully merging this pull request may close these issues.

None yet

1 participant