Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate AsdfFile attrs and methods that use legacy extension api #1417

Merged
merged 3 commits into from
Feb 21, 2023

Conversation

braingram
Copy link
Contributor

Deprecate:

  • run_hook
  • run_modifying_hook
  • url_mapping
  • tag_mapping
  • type_index
  • resolver
  • extension_list

asdf/asdf.py Outdated Show resolved Hide resolved
@braingram braingram marked this pull request as ready for review February 21, 2023 16:24
@braingram braingram requested a review from a team as a code owner February 21, 2023 16:24
Deprecate:
- run_hook
- run_modifying_hook
- url_mapping
- tag_mapping
- type_index
- resolver
- extension_list
@WilliamJamieson WilliamJamieson merged commit dd67489 into asdf-format:master Feb 21, 2023
@lumberbot-app
Copy link

lumberbot-app bot commented Feb 21, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.15.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 dd67489e660d2115444d9a71186244e7ad5ea875
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #1417: deprecate AsdfFile attrs and methods that use legacy extension api'
  1. Push to a named branch:
git push YOURFORK 2.15.x:auto-backport-of-pr-1417-on-2.15.x
  1. Create a PR against branch 2.15.x, I would have named this PR:

"Backport PR #1417 on branch 2.15.x (deprecate AsdfFile attrs and methods that use legacy extension api)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@WilliamJamieson
Copy link
Contributor

@meeseeksdev backport to 2.15.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants