Move array storage settings to config

[braingram]

This PR moves:

• all_array_storage
• all_array_compression
• all_array_compression_kwargs

into asdf.config.AsdfConfig. These were previously passed around as arguments to several functions during AsdfFile writes. By moving them into the config the AsdfFile can continue to accept them as arguments to AsdfFile.write_to and AsdfFile.update (by using the arguments to set the values in the AsdfConfig context created within those functions) and now users can also adjust these settings in the config directly.

This helps to make these storage settings available to all functions called within the AsdfConfig contexts created during write without having to pass them around as arguments (this proved important for the upcoming deferred block and Converter block storage support).

[perrygreenfield]

Let me see if I understand correctly. The main advantage is to remove the necessity of passing ctx as an argument to many of these functions to clean up the interface? Otherwise the changes look good to me. I just want to make sure I understand the the goal.

[braingram]

Let me see if I understand correctly. The main advantage is to remove the necessity of passing ctx as an argument to many of these functions to clean up the interface? Otherwise the changes look good to me. I just want to make sure I understand the the goal.

Exactly!

It also allows everything within the context to have access to the setting. For example the eventual ndarray converter will benefit from access to these settings during a call to to_yaml_tree. Currently to_yaml_tree only receives a SerializationContext (as the ctx argument) and not a reference to the AsdfFile (where the settings are located prior to this PR). With this PR the all_array_storage (etc) settings are available within the scope of the call to Converter.to_yaml_tree.

[perrygreenfield]

LGTM

[braingram]

LGTM

Thanks for reviewing this. I rebased it to main and will enable auto-merge.

[eslavich]

@braingram sorry to ceiling-cat this closed PR, but it occurred to me that this is a nice opportunity to combine the compression-related setters into a single method call. It seems odd that our interface forces us to set them separately, since afaik they will always go together, and if we change the compression algorithm we probably should at least wipe out the kwargs from the previous algorithm.

Also, wdyt about changing the name and semantics of these config item to be "default" instead of "all"? The "all" can be an awkward tool sometimes, since you can't modify the compression of individual arrays if you use an "all" setting. For example, if your AsdfFile has 100 arrays and you want to use blosc for 99 of them and no compression for the remaining array, all_array_compression isn't useful, instead you have to call AsdfFile.set_array_compression on all 99.

Anyway no pressure to make changes, I just had to get out some ideas that have been in the back of my head about these.

[braingram]

Those all sounds like good improvements to me. I opened an issue to track the changes:
#1503
Given that this PR won't be released until the first 3.0 release, I milestoned the issue for 3.0 so we can make the change to the config api before it's made public (so no deprecation warning should be needed, although we will need to deprecate the arguments to open).