issue warning if manifest id does not match uri #1785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
force-pushed
the
manifest_extension_mismatch
branch
4 times, most recently
from
f863ec6
to
c872a3f
Compare
5 tasks
braingram
force-pushed
the
manifest_extension_mismatch
branch
from
c872a3f
to
5717f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#1758 assumed that the
uriused for a manifest matches theidin the manifest. This should be the case (as defined in the extension manifest schema). However this was not previously being checked. Both dkist and weldx downstream jobs show failures since both these packages use manifests with ids that do not match the uris. The dkist failure is due to use of sunpy manifests (which are fixed in main but are unreleased) and a PR is open for weldx to update the ids to match.This PR detects the mismatch and instead of producing an exception issues a new warning
AsdfManifestURIMismatchWarningwith a message to file an issue with the package maintainers.The weldx downstream job (which doesn't turn warnings into errors) shows the new warning:
https://github.com/asdf-format/asdf/actions/runs/9004808168/job/24738692670?pr=1785#step:10:714
A warning filter is added in this PR to the
tox.inito filter out the warning for the dkist downstream job since it's an issue with the sunpy manifests and will be fixed in the next major sunpy release.Checklist: