Skip to content

Commit

Permalink
feat: remove previous integrity check logic
Browse files Browse the repository at this point in the history
  • Loading branch information
augustobmoura committed Nov 24, 2021
1 parent c4e335f commit ee8daa2
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 83 deletions.
38 changes: 0 additions & 38 deletions bin/import-previous-release-team-keyring

This file was deleted.

43 changes: 0 additions & 43 deletions bin/import-release-team-keyring

This file was deleted.

3 changes: 2 additions & 1 deletion bin/install
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,8 @@ install_canon_version() {
fi

ensure_nodebuild_updated
NODE_BUILD_BUILD_PATH="$ASDF_DOWNLOAD_PATH" \

NODE_BUILD_BUILD_PATH="$ASDF_DOWNLOAD_PATH" NODE_BUILD_CACHE_PATH="$ASDF_DOWNLOAD_PATH" \
nodebuild_wrapped -v "${nodebuild_args[@]}" "$version" "$install_path"
}

Expand Down
2 changes: 1 addition & 1 deletion lib/commands/command-nodebuild.bash
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ if [ "$NODEJS_ORG_MIRROR" ]; then
export NODE_BUILD_MIRROR_URL="$NODEJS_ORG_MIRROR"
fi

if [[ $ASDF_NODEJS_CONCURRENCY =~ ^[0-9]+$ ]]; then
if [[ "${ASDF_NODEJS_CONCURRENCY-}" =~ ^[0-9]+$ ]]; then
export MAKE_OPTS="${MAKE_OPTS:-} -j$ASDF_NODEJS_CONCURRENCY"
export NODE_MAKE_OPTS="${NODE_MAKE_OPTS:-} -j$ASDF_NODEJS_CONCURRENCY"
fi
Expand Down

2 comments on commit ee8daa2

@calebds
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the release-team-keyring files removed intentionally?

@augustobmoura
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the release-team-keyring files removed intentionally?

Yes, we don't check integrity based on signatures anymore. Instead, we are using node-build behind the scenes of the installation, it already makes a simple checksum test. Because the checksums are pre-computed ahead of time and versioned with the tool, we can guarantee the integrity of the packages.

Please sign in to comment.