-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Gemfile when available #76
Conversation
Does this work as expected? |
bin/get-version-from-legacy-file
Outdated
fi | ||
} | ||
|
||
get_legacy_version "$1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we need to implement a script named bin/list-legacy-filenames
if we are removing this file.
Thanks @Seanstoppable for doing this, really happy to see this idea moving forward! |
@Seanstoppable @Stratus3D is there anything I can to do help move this forward? My team is considering dropping the |
Order now goes: .ruby-version Gemfile .tool-versions Global asdf setting Adapted rbenv script from https://github.com/aripollak/rbenv-bundler-ruby-version/blob/master/bin/rbenv-bundler-ruby-version Enhanced existing script to do similar thing Renamed script file such that it will actually do parsing
I believe this is complete now. travis errors seem agnostic of this branch. Just waiting for further feedback if necessary |
Any update on this? Really looking forward to this being added |
@Stratus3D is there anyway we can get this reviewed/merged? There seems to be a number of people wanting this feature and it seems ready. Thanks for all you do, I know maintaining is a lot of work and I appreciate the great tooling. |
It doesn't look like rbenv supports this either: rbenv/rbenv#223. Assuming it's always a hardcoded version and not a range that's present in the Gemfile I'm fine with merging this. It's clear many would find this useful. |
@Seanstoppable can you rebase? It looks like there are more recent changes to |
Thank you! |
Order now goes:
.ruby-version
Gemfile
.tool-versions
Global asdf setting
Adapted rbenv script from https://github.com/aripollak/rbenv-bundler-ruby-version/blob/master/bin/rbenv-bundler-ruby-version
Enhanced existing script to do similar thing
Renamed script file such that it will actually do parsing