Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Gemfile when available #76

Merged
merged 4 commits into from
Feb 15, 2019
Merged

Use Gemfile when available #76

merged 4 commits into from
Feb 15, 2019

Conversation

Seanstoppable
Copy link
Contributor

Order now goes:
.ruby-version
Gemfile
.tool-versions
Global asdf setting

Adapted rbenv script from https://github.com/aripollak/rbenv-bundler-ruby-version/blob/master/bin/rbenv-bundler-ruby-version
Enhanced existing script to do similar thing
Renamed script file such that it will actually do parsing

@Seanstoppable Seanstoppable mentioned this pull request Sep 14, 2018
@Stratus3D
Copy link
Member

Does this work as expected?

fi
}

get_legacy_version "$1"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we need to implement a script named bin/list-legacy-filenames if we are removing this file.

bin/parse-legacy-file Outdated Show resolved Hide resolved
@drapergeek
Copy link

Thanks @Seanstoppable for doing this, really happy to see this idea moving forward!

@drapergeek
Copy link

@Seanstoppable @Stratus3D is there anything I can to do help move this forward? My team is considering dropping the .ruby-version file so it's become more of a necessity for me. Happy to help out.

Sean Smith added 3 commits November 29, 2018 09:59
Order now goes:
.ruby-version
Gemfile
.tool-versions
Global asdf setting

Adapted rbenv script from https://github.com/aripollak/rbenv-bundler-ruby-version/blob/master/bin/rbenv-bundler-ruby-version
Enhanced existing script to do similar thing
Renamed script file such that it will actually do parsing
@Seanstoppable
Copy link
Contributor Author

I believe this is complete now. travis errors seem agnostic of this branch. Just waiting for further feedback if necessary

@skipkayhil
Copy link

Any update on this? Really looking forward to this being added

@drapergeek
Copy link

@Stratus3D is there anyway we can get this reviewed/merged? There seems to be a number of people wanting this feature and it seems ready. Thanks for all you do, I know maintaining is a lot of work and I appreciate the great tooling.

@Stratus3D
Copy link
Member

It doesn't look like rbenv supports this either: rbenv/rbenv#223. Assuming it's always a hardcoded version and not a range that's present in the Gemfile I'm fine with merging this. It's clear many would find this useful.

@Stratus3D
Copy link
Member

@Seanstoppable can you rebase? It looks like there are more recent changes to bin/parse-legacy-file. I'll merge as soon as the conflict is resolved, or when I get a chance to fix it myself.

@Stratus3D Stratus3D merged commit 0654c89 into asdf-vm:master Feb 15, 2019
@drapergeek
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants