fix: lint & style errors in bin/asdf (#1516)

bin/asdf

@@ -16,9 +16,9 @@ find_cmd() {
   done
 
   if [ -f "$cmd_dir/$cmd_name" ]; then
-    printf "%s %s\\n" "$cmd_dir/$cmd_name" "$((args_offset + 1))"
+    printf "%s %s\n" "$cmd_dir/$cmd_name" "$((args_offset + 1))"
   elif [ -f "$cmd_dir/command.bash" ]; then
-    printf "%s %s\\n" "$cmd_dir/command.bash" 1
+    printf "%s %s\n" "$cmd_dir/command.bash" 1
   fi
 }
 
@@ -29,15 +29,15 @@ find_asdf_cmd() {
   'exec' | 'current' | 'env' | 'global' | 'install' | 'latest' | 'local' | \
     'reshim' | 'uninstall' | 'update' | 'where' | 'which' | \
     'export-shell-version')
-    printf "%s %s\\n" "$asdf_cmd_dir/command-$1.bash" 2
+    printf "%s %s\n" "$asdf_cmd_dir/command-$1.bash" 2
     ;;
 
   '' | '--help' | '-h' | 'help')
-    printf "%s %s\\n" "$asdf_cmd_dir/command-help.bash" 2
+    printf "%s %s\n" "$asdf_cmd_dir/command-help.bash" 2
     ;;
 
   '--version' | 'version')
-    printf "%s %s\\n" "$asdf_cmd_dir/command-version.bash" 2
+    printf "%s %s\n" "$asdf_cmd_dir/command-version.bash" 2
     ;;
 
   *)
@@ -55,15 +55,15 @@ find_plugin_cmd() {
     args_offset=${result##* }
     if [ -n "$ASDF_CMD_FILE" ]; then
       args_offset=$((args_offset + 1)) # since the first argument is the plugin name
-      printf "%s %s\\n" "$ASDF_CMD_FILE" "$args_offset"
+      printf "%s %s\n" "$ASDF_CMD_FILE" "$args_offset"
     fi
   fi
 }
 
 asdf_cmd() {
   local ASDF_CMD_FILE args_offset
 
-  if [ "shell" == "$1" ]; then
+  if [ "shell" = "$1" ]; then
     printf "Shell integration is not enabled. Please ensure you source asdf in your shell setup." >&2
     exit 1
   fi
@@ -86,7 +86,7 @@ asdf_cmd() {
   else
     local asdf_cmd_dir
     asdf_cmd_dir="$(asdf_dir)/lib/commands"
-    printf "%s\\n" "Unknown command: \`asdf ${*}\`" >&2
+    printf "%s\n" "Unknown command: \`asdf ${*}\`" >&2
     . "$asdf_cmd_dir/command-help.bash" >&2
     return 127
   fi

scripts/checkstyle.py

@@ -8,17 +8,17 @@
 # This file checks Bash and Shell scripts for violations not found with
 # shellcheck or existing methods. You can use it in several ways:
 #
-# Lint all .bash, .sh, and .bats files and print out violations
+# Lint all .bash, .sh, .bats files along with 'bin/asdf' and print out violations:
 # $ ./scripts/checkstyle.py
 #
 # The former, but also fix all violations. This must be ran until there
-# are zero violations since any line can have more than one violation
+# are zero violations since any line can have more than one violation:
 # $ ./scripts/checkstyle.py --fix
 #
-# Lint a particular file
+# Lint a particular file:
 # $ ./scripts/checkstyle.py ./lib/functions/installs.bash
 #
-# Check to ensure all regexes are working as intended
+# Check to ensure all regular expressions are working as intended:
 # $ ./scripts/checkstyle.py --internal-test-regex
 
 Rule = Dict[str, Any]
@@ -35,7 +35,7 @@ class c:
     UNDERLINE = '\033[4m'
     LINK: Callable[[str, str], str] = lambda href, text: f'\033]8;;{href}\a{text}\033]8;;\a'
 
-def utilGetStrs(line, m):
+def utilGetStrs(line: Any, m: Any):
     return (
         line[0:m.start('match')],
         line[m.start('match'):m.end('match')],
@@ -44,22 +44,22 @@ def utilGetStrs(line, m):
 
 # Before: printf '%s\\n' '^w^'
 # After: printf '%s\n' '^w^'
-def noDoubleBackslashFixer(line: str, m) -> str:
+def noDoubleBackslashFixer(line: str, m: Any) -> str:
     prestr, midstr, poststr = utilGetStrs(line, m)
 
     return f'{prestr}{midstr[1:]}{poststr}'
 
 # Before: $(pwd)
 # After: $PWD
-def noPwdCaptureFixer(line: str, m) -> str:
-    prestr, midstr, poststr = utilGetStrs(line, m)
+def noPwdCaptureFixer(line: str, m: Any) -> str:
+    prestr, _, poststr = utilGetStrs(line, m)
 
     return f'{prestr}$PWD{poststr}'
 
 # Before: [ a == b ]
 # After: [ a = b ]
-def noTestDoubleEqualsFixer(line: str, m) -> str:
-    prestr, midstr, poststr = utilGetStrs(line, m)
+def noTestDoubleEqualsFixer(line: str, m: Any) -> str:
+    prestr, _, poststr = utilGetStrs(line, m)
 
     return f'{prestr}={poststr}'
 
@@ -68,7 +68,7 @@ def noTestDoubleEqualsFixer(line: str, m) -> str:
 # ---
 # Before: function fn { ...
 # After fn() { ...
-def noFunctionKeywordFixer(line: str, m) -> str:
+def noFunctionKeywordFixer(line: str, m: Any) -> str:
     prestr, midstr, poststr = utilGetStrs(line, m)
 
     midstr = midstr.strip()
@@ -183,14 +183,14 @@ def main():
     if args.internal_test_regex:
         for rule in rules:
             for positiveMatch in rule['testPositiveMatches']:
-                m = re.search(rule['regex'], positiveMatch)
+                m: Any = re.search(rule['regex'], positiveMatch)
                 if m is None or m.group('match') is None:
                     print(f'{c.MAGENTA}{rule["name"]}{c.RESET}: Failed {c.CYAN}positive{c.RESET} test:')
                     print(f'=> {positiveMatch}')
                     print()
 
             for negativeMatch in rule['testNegativeMatches']:
-                m = re.search(rule['regex'], negativeMatch)
+                m: Any = re.search(rule['regex'], negativeMatch)
                 if m is not None and m.group('match') is not None:
                     print(f'{c.MAGENTA}{rule["name"]}{c.RESET}: Failed {c.YELLOW}negative{c.RESET} test:')
                     print(f'=> {negativeMatch}')
@@ -210,7 +210,7 @@ def main():
                 lintfile(p, rules, options)
     else:
         for file in Path.cwd().glob('**/*'):
-            if file.name.endswith('.bash') or file.name.endswith('.sh') or file.name.endswith('.bats'):
+            if file.name.endswith('.bash') or file.name.endswith('.sh') or file.name.endswith('.bats') or str(file.absolute()).endswith('bin/asdf'):
                 if file.is_file():
                     lintfile(file, rules, options)