Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: The "asdf version" command should not allow additional parameters and report them as an error #1674

Open
aognio opened this issue Nov 3, 2023 · 1 comment
Labels

Comments

@aognio
Copy link
Contributor

aognio commented Nov 3, 2023

Describe the Bug

If you run asdf version python (which I was mistakenly typing instead of asdf list python) you will get a version number which belongs to the ASDF tool itself not to the plugin.

So asdf version is basically ignoring any extra paramenter.

If you run asdf version a b c d it will still happily print the current ASDF version number.

Steps to Reproduce

  1. Type asdf version a b c d
  2. Check that the current version of ASDF gets printed with any error message indicating that the command does not take any extra parameters.

Expected Behaviour

If I type asdf version python or asdf version something else I should get a error message like the following:

The asdf version command does not take any extra parameter

Actual Behaviour

Right now it will print the currently installed version of ASDF.

Environment

OS:
Linux DESKTOP-PI97MVD 5.15.90.1-microsoft-standard-WSL2 #1 SMP Fri Jan 27 02:56:13 UTC 2023 x86_64 x86_64 x86_64 GNU/Linux

SHELL:
GNU bash, version 5.1.16(1)-release (x86_64-pc-linux-gnu)
Copyright (C) 2020 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>

This is free software; you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.

BASH VERSION:
5.1.16(1)-release

ASDF VERSION:
v0.13.1-0586b37

ASDF INTERNAL VARIABLES:
ASDF_DEFAULT_TOOL_VERSIONS_FILENAME=.tool-versions
ASDF_DATA_DIR=/home/gnrfan/.asdf
ASDF_DIR=/home/gnrfan/.asdf
ASDF_CONFIG_FILE=/home/gnrfan/.asdfrc

ASDF INSTALLED PLUGINS:
crystal                      https://github.com/asdf-community/asdf-crystal.git master 6b5c52a
dart                         https://github.com/PatOConnor43/asdf-dart.git master 0ece407
deno                         https://github.com/asdf-community/asdf-deno.git master 87442fe
dmd                          https://github.com/sylph01/asdf-dmd.git master ec366a3
dotnet                       https://github.com/hensou/asdf-dotnet main be1cd7d
golang                       https://github.com/kennyp/asdf-golang.git master 21d9c32
lua                          https://github.com/Stratus3D/asdf-lua.git master 36fae6e
nodejs                       https://github.com/asdf-vm/asdf-nodejs.git master 4f8aa3d
python                       https://github.com/danhper/asdf-python.git master 8505457
ruby                         https://github.com/asdf-vm/asdf-ruby.git master c51c43f
rust                         https://github.com/code-lever/asdf-rust.git master 95acf4f
swift                        https://github.com/fcrespo82/asdf-swift.git master 23dbd46
zig                          https://github.com/cheetah/asdf-zig.git master d88f6db

asdf plugins affected (if relevant)

No response

@aognio aognio added the bug label Nov 3, 2023
@hyperupcall
Copy link
Contributor

I'm inclined to close this as an individual issue - our CLI has a contract thatt's pretty narrow. so this issue extends not just for asdf version, but all the other subcommands too. I've been meaning to work on this, but I wanted #1456 to be merged first

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants