Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interrupted downloads are being treated as complete installs #214

Closed
mselee opened this issue Jul 30, 2017 · 3 comments
Closed

Interrupted downloads are being treated as complete installs #214

mselee opened this issue Jul 30, 2017 · 3 comments

Comments

@mselee
Copy link

mselee commented Jul 30, 2017

If you start installing a version of a language (e.g. Erlang) and for some reason it gets interrupted (e.g. Ctrl-C), it will be treated as a complete installation, meaning:

$ asdf install erlang 20.0
erlang 20.0 is already installed

But

$ iex
No such command in 20.0 of erlang

And .asdf/installs/erlang/20.0/ path is empty.

The workaround is simple: uninstall erlang and reinstall it again but that's not ideal unless you are previously aware of this issue.

@danhper
Copy link
Member

danhper commented Jul 30, 2017

We are actually checking for the return code in asdf, so this is more of a per-plugin issue.
I know some plugins do have this issue, let's open an issue in asdf-erlang to start with.

@Stratus3D
Copy link
Member

I see the bug in asdf-erlang. Thanks for reporting!

@danhper
Copy link
Member

danhper commented Jul 30, 2017

There is indeed an issue in the asdf-erlang plugin, but I just realized that the situation is a little when receiving the sigint signal. We do need to trap it somewhere if we want to cleanup cleanly, so I added the logic to do so inside the install command.
We still need to handle download failures in asdf-erlang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants