chore: fix ShellCheck errors in tests #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyperupcall
changed the title
jthegedus
reviewed
Jan 21, 2023
jthegedus
reviewed
Jan 21, 2023
jthegedus
reviewed
Jan 21, 2023
jthegedus
approved these changes
Jan 21, 2023
jthegedus
requested changes
Jan 21, 2023
There was a problem hiding this comment.
See comments for requested changes.
I will approve & merge afterwards, cheers!
I know this is a slow process, sorry @hyperupcall your help is appreciated 🙏
hyperupcall
force-pushed
the
test-shellcheck-1
branch
2 times, most recently
from
8dc86c9
to
aef5eb3
Compare
hyperupcall
force-pushed
the
test-shellcheck-1
branch
from
aef5eb3
to
f4b4d11
Compare
|
Rebased over |
jthegedus
approved these changes
Jan 22, 2023
jthegedus
changed the title
|
On to the next! |
|
woot! |
This was referenced Jan 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR is the first of a multi-part series that fixes various issues with the tests. I broke this change up as to be easier to review, and it seemed similar to #1349, in which different PRs were preferred over a single larger one.
Here is a description of each commit/part:
$?withrun(chore: Fix ShellCheck errors in tests #1451)At the end of the commit series, some lints were disabled:
test/reshim_command.batssince I wanted to be sure not to break any tests and the conversion tofindisn't as trivial as the other fixes - it can be fixed later.Partially addresses #1396