fix: rename internal function asdf_tool_versions_filename
#1544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jthegedus
approved these changes
Apr 17, 2023
|
@Stratus3D are you happy with these changes? |
jthegedus
requested changes
Apr 17, 2023
There was a problem hiding this comment.
I know this is annoying, but can we have two PRs for these changes.
One with the rename, the other with the improved nullglob change?
The PR titles end up in the Changelog so we would ideally like PRs with one change so we can name the PRs and therefore changelog better.
hyperupcall
force-pushed
the
small-fixes
branch
from
5fc8d94
to
e5b6b0b
Compare
hyperupcall
changed the title
asdf_default_tool_versions_filename
jthegedus
changed the title
asdf_default_tool_versions_filenameasdf_tool_versions_filename
|
Looks good to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Applied suggestions from here and here.