fix: Make sure that files with + in their name get escaped #1555
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickomatic
force-pushed
the
fix-bash-utils-escaping
branch
2 times, most recently
from
b4317f0
to
685734f
Compare
patrickomatic
changed the title
otherwise if you have a command like g++, csv++ you will see the following error: grep: repetition-operator operand invalid PATCH: fixes a bug for keys with `+` characters
patrickomatic
force-pushed
the
fix-bash-utils-escaping
branch
from
685734f
to
46ec2fb
Compare
patrickomatic
force-pushed
the
fix-bash-utils-escaping
branch
from
fc62102
to
0b3a23d
Compare
|
This change seems to have no effect on how files with And the code seems to indicate that this escaping is only for keys of the config file ( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Hi, I'm working on a program with
++in the name, similar tog++and I noticed that calling it produces this grep error.So included is just a change that escapes the core regexp characters that could occur in a filename
Fixes: List issue numbers here
Other Information