Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Introduce ASDF_FORCE_PREPEND variable on POSIX entrypoint #1560

Merged
merged 7 commits into from
Jun 9, 2023
Merged

fix: Introduce ASDF_FORCE_PREPEND variable on POSIX entrypoint #1560

merged 7 commits into from
Jun 9, 2023

Conversation

hyperupcall
Copy link
Contributor

Summary

This variable forces the prepending of the asdf directories to the PATH variable. It does this by removing existing asdf entries in PATH, including an optimization for Bash and Zsh shells.

Fixes #1550

@hyperupcall hyperupcall requested a review from a team as a code owner May 27, 2023 06:11
@hyperupcall hyperupcall mentioned this pull request May 27, 2023
Closed
@hyperupcall
fix: Introduce ASDF_FORCE_PREPEND variable on POSIX entrypoint
6e6de80 
This variable forces the prepending of the asdf directories to the PATH
variable. It does this by removing existing asdf entries in PATH,
including an optimization for Bash and Zsh shells.
@hyperupcall
docs(tweak): Improve wording
f7a12db
@hyperupcall
Copy link
Contributor Author

I'm starting to think that this should be the default on macOS, so users don't end up having to set environment variables when they update. Thoughts?

@jthegedus
Copy link
Contributor

I'm starting to think that this should be the default on macOS, so users don't end up having to set environment variables when they update. Thoughts?

That's probably best. I would like to see the code you would suggest for that.

@hyperupcall
Copy link
Contributor Author

I changed things from relying on the existence of a set variable, to the value of the variable. Now there is documentation which explains the behavior

Stratus3D
Stratus3D reviewed Jun 5, 2023
View reviewed changes
asdf.sh Show resolved Hide resolved
@Stratus3D
Copy link
Member

Just tested these changes and confirmed they fixed my issue with the path inside tmux sessions.

@hyperupcall hyperupcall mentioned this pull request Jun 5, 2023
Merged
@Stratus3D
Copy link
Member

@jthegedus are you good with this now?

@Stratus3D
Copy link
Member

Merge so I can easily get this fix on my machines. @jthegedus happy to revert this change if you find issues with what is here.

@Stratus3D Stratus3D merged commit 5b7d0fe into asdf-vm:master Jun 9, 2023
7 checks passed
@github-actions github-actions bot mentioned this pull request Jun 9, 2023
Merged
@hyperupcall hyperupcall deleted the h-path-order branch June 9, 2023 02:25
@jthegedus
Copy link
Contributor

@jthegedus are you good with this now?

Yeah, this looks like a good soln for this problem 💯

@chenrui333 chenrui333 mentioned this pull request Jun 15, 2023
Merged
This was referenced Jun 15, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jthegedus jthegedus jthegedus left review comments

@Stratus3D Stratus3D Stratus3D approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: PATH order situationally broken on MacOS
3 participants
@hyperupcall @jthegedus @Stratus3D