Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added shell completions for zsh #744

Closed
wants to merge 1 commit into from
Closed

Added shell completions for zsh #744

wants to merge 1 commit into from

Conversation

LexMalta
Copy link

@LexMalta LexMalta commented Jun 15, 2020

Summary

Simple script to get shell/bash completions for zsh working.

I honestly don't know much about shell completions or how they work, but a quick bit of googling found: eddiezane/lunchy#59 (comment) .I tried that locally and it worked for me - figured it would be worth sharing upstream.

Are there any docs that need to be updated?

@LexMalta LexMalta requested a review from a team as a code owner June 15, 2020 06:10
@jthegedus
Copy link
Contributor

jthegedus commented Jun 15, 2020

Hi mate, thanks for contributing.

Unfortunately, this is code we used to have in our repo but have since removed. This implementation of using the Bash completions was how we originally supported ZSH users for a few years, but we now have native ZSH completions.

Issues covering that reversal are here #674 #692

The documentation site https://asdf-vm.com/#/core-manage-asdf-vm covers how to setup the Shell completions for ZSH vs Bash etc.

If you find yourself itching to contribute more we have plenty of improvements to make, thanks!

@jthegedus jthegedus closed this Jun 15, 2020
@LexMalta LexMalta deleted the zsh-shell-completions branch June 16, 2020 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants