New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: configurable plugin repo last check time #957
Conversation
Hi @NeoHsu thanks for proposing this change, I think we do need to communicate this better. I have been thinking about making a change like this. Some background on this:
Your proposal splits the functionality of the plugin repo update into two:
I think there is a more simple and user-configurable solution that gives us both results without the split in functionality:
What do you think of this suggestion? |
That's cool !! But I think print plugins updates is very important. Thanks for getting back to me. |
924e64b
to
b658e9d
Compare
Hi @jthegedus , |
2df30ab
to
b4886af
Compare
This is looking like a good improvement @NeoHsu @Stratus3D do you have thoughts here? I am not sure how portable the |
b4886af
to
dc62ccb
Compare
Hi @jthegedus, I'm finish now, |
This change works great 🎉 I'm going to write a couple of tests for this:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me now. Thanks again
Sorry I missed your comment. I am not sure either, but I also don't see folks online reporting any issues with the flag not being supported, so I guess we will see how it goes. I agree this is a nice improvement. Is there a way to turn off checking completely? e.g. is there another configuration option for that? Or can I somehow set this last check time to infinity? |
Good questions. I would prefer a solution that does not require another config option. I believe the numeric value for |
I would like something like |
Summary
Add update plugins repo function to
asdf plugin-update
command that can be get latest asdf plugins listHi everyone,
I tried to update the asdf plugins today,
but I didn't get latest plugins list.
I can't find a way to update asdf plugin list,
so I implement this function in plugin update command.
I think about plugin update command for user flow,
When user want to update plugin,
they maybe want to get latest plugin list,
so I add trigger function on plugin update command.
I hope to help this project to be better.
Thanks.