Add ability to trigger errors in mock http mode #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 91.3% 92.39% +1.09%
==========================================
Files 9 9
Lines 207 263 +56
==========================================
+ Hits 189 243 +54
- Misses 12 13 +1
- Partials 6 7 +1
Continue to review full report at Codecov.
|
zlozano
previously approved these changes
May 13, 2019
bkrebsbach
previously approved these changes
May 13, 2019
Add ability to document errors returned by any function. Add special headers to trigger errors while in mock mode. Note that only HTTP mode is supported as there is no mechanism for conveying a trigger through vanilla lambda. If we were to build a real or mock version of the lambda binary then the only way to interact with it is through the real lambda API or through the real AWS API Gateway. Neither of these enable us to add a trigger within a function or within a function decorator because they do not convey the state that we need without modifying the request body. As a result, this only works for HTTP mode but can still be used to test serverfull-gateway templates.
This prevent the tests from failing on a system that has port 9090 in use by selecting a port that is known to be available.
kconwayatlassian
force-pushed
the
mock-errors
branch
from
a1e95ac
to
b09b931
Compare
|
I had to rebase after merging log/stat injection. I also added a commit that adds dynamic port selection for the integration tests so we don't rely on a single "magic" port number. |
bkrebsbach
approved these changes
May 14, 2019
zlozano
approved these changes
May 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to document errors returned by any function.
Add special headers to trigger errors while in mock mode.
Note that only HTTP mode is supported as there is no mechanism for
conveying a trigger through vanilla lambda. If we were to build a real
or mock version of the lambda binary then the only way to interact with
it is through the real lambda API or through the real AWS API Gateway.
Neither of these enable us to add a trigger within a function or within
a function decorator because they do not convey the state that we need
without modifying the request body. As a result, this only works for
HTTP mode but can still be used to test serverfull-gateway templates.