Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Heroku deploy button #15

Merged
merged 1 commit into from Sep 22, 2014
Merged

Add Heroku deploy button #15

merged 1 commit into from Sep 22, 2014

Conversation

albertoperdomo
Copy link
Contributor

This PR adds a Heroku deploy button as an alternative way to deploy the template app.

aseemk added a commit that referenced this pull request Sep 22, 2014
@aseemk aseemk merged commit 8934382 into aseemk:master Sep 22, 2014
@aseemk
Copy link
Owner

aseemk commented Sep 22, 2014

Thanks @albertoperdomo!

@albertoperdomo
Copy link
Contributor Author

Hey @aseemk,

after opening this PR, @jexp told me there is more up-to-date template repo for node-neo4j at https://github.com/neo4j-examples/node-neo4j-template.

From my POV it looks that both repos are out of sync or something, with some recent updates on yours and on theirs too.

Do you have a suggestion on moving forward?

I'd like to see a Heroku deploy on the driver repo, but the question is which template repo it should be based on.

We also want to know which of the template repos to reference from our Heroku docs.

@albertoperdomo
Copy link
Contributor Author

Ping @aseemk

@aseemk
Copy link
Owner

aseemk commented Sep 30, 2014

Oops sorry for the delay!

Yep, the two repos are branched. The difference is mainly just issue #11 (new-style indexing), which I do want to implement here. We've done that at @fiftythree, so I'll definitely look to update this here soon.

More importantly, now that we've shipped Mix, I want to use this repo as a playground to share some of the ideas we built (and which we want to open-source) for it, e.g. around programmatic query generation.

If all goes well, this repo will be the start of a higher-level "OGM" for Neo4j on Node.js.

Just spread thin at the moment — wish I had more time in the day. =)

@albertoperdomo
Copy link
Contributor Author

Oh, good to know!
Looking forward to see those ideas in practice!
Thanks @aseemk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants