Use Ruby's ISO8601 time formatter and parser #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This could be considered a breaking change, as it modifies the string generated for a Time, to include a colon separator between the hour and minute of the time zone, so +01:00 instead of +0100.
|
Any thoughts on this? |
|
Cool, thanks! |
asenchi
added a commit
that referenced
this pull request
Sep 26, 2013
Use Ruby's ISO8601 time formatter and parser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes two changes:
It slightly modifies the generated time string to include a colon between the hour and minute in the time zone. For example: +01:00 instead of +0100.
It adds Time support to the parser, by running it through Ruby's ISO8601 time formatter, and skipping over the output if it's not an ISO8601 string. This could have performance implications.