Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Route color #36

Closed
ivanjolic95 opened this issue Mar 13, 2016 · 5 comments
Closed

Route color #36

ivanjolic95 opened this issue Mar 13, 2016 · 5 comments

Comments

@ivanjolic95
Copy link
Contributor

While working on #35 I tried to add color option to route component but I couldn't make it work.

I suppose this should be added to rendererOptions for direction renderer in g-map-route component:

let color = this.get('color');
...
polylineOptions: {
  strokeColor: color
}

For some reason it didn't work. Can you please look into it? Thanks!

@asennikov
Copy link
Owner

Yeah, will look into this, would be definitely good to be able to change color of those lines.

@asennikov
Copy link
Owner

Looks like I was able to do that. Check it out at #38, I'm going to add some tests and release it soon.

@ivanjolic95
Copy link
Contributor Author

Thanks! I've added a basic "waypoints" option to route (passing an array of waypoints as it's specified in maps api) .

I'd like to extract them into g-map-waypoint component though, so they can be added within a g-map-route block. What do you think of that approach?

If it's okay I'll make a pull request next week.

@asennikov
Copy link
Owner

Sounds perfect!

@asennikov
Copy link
Owner

Route colors (and some other polyline options) are available in 0.0.16, so I'm closing this issue.

Waiting for that waypoints PR though 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants