Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polyline options for Routes #38

Merged
merged 3 commits into from
Mar 26, 2016
Merged

Polyline options for Routes #38

merged 3 commits into from
Mar 26, 2016

Conversation

asennikov
Copy link
Owner

Some better styling for polylines produced by {{g-map-route}} and {{g-map-address-route}} components.
Available options:

  • strokeColor
  • strokeWeight
  • strokeOpacity
  • zIndex

image

@asennikov asennikov mentioned this pull request Mar 18, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-1.3%) to 98.75% when pulling 35519f2 on polyline-options into 7abd38d on master.

@kirantpatil
Copy link

Sir, is there availability to show distance in km of the route ?

@asennikov
Copy link
Owner Author

@kirantpatil currently there's no such option.

But looks like Google Maps API provides an ability to calculate total distance by summing legs of the route https://developers.google.com/maps/documentation/javascript/directions#Routes
So it would be better to open another issue for this feature request or if you feel like you can handle this - a PR 😉

@kirantpatil
Copy link

@asennikov our developer is junior and I will assist my best and at the same time it may require your guidance as well.

What is your opinion shall we go ahead or will you or anyone from community take it up ?

@asennikov
Copy link
Owner Author

We should probably start with moving this conversation to a separate Issue in this repository, since current PR is about a bit different feature.

Signed-off-by: Alexander Sennikov <gseno88@gmail.com>
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 9bb3a67 on polyline-options into 7abd38d on master.

@asennikov asennikov changed the title [WIP] Polyline options for Routes Polyline options for Routes Mar 26, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling b880cbb on polyline-options into 7abd38d on master.

@asennikov asennikov merged commit a5d039d into master Mar 26, 2016
@asennikov asennikov deleted the polyline-options branch March 26, 2016 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants