Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "removing protocol relative url" #45

Merged
merged 1 commit into from
Apr 24, 2016
Merged

Conversation

asennikov
Copy link
Owner

Reverts #43

@asennikov asennikov self-assigned this Apr 24, 2016
@asennikov
Copy link
Owner Author

Heu @mansona, I've merged your PR but then realised, that we already have support for setting protocol directly on demand.

See this old PR for details - #26 I'll add this info to docs.

@asennikov
Copy link
Owner Author

Actually, we already have it noted here - https://github.com/asennikov/ember-g-map#configuration

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d6440b1 on revert-43-master into f41b665 on master.

@asennikov asennikov merged commit be352e6 into master Apr 24, 2016
@asennikov asennikov deleted the revert-43-master branch April 24, 2016 10:22
@mansona
Copy link
Contributor

mansona commented Apr 25, 2016

@asennikov that seems like an extraneous configuration now that protocol relative urls are considered an anti-pattern? maybe having the default be https would be better?

Would you like me to put together a PR that puts the default as https?

@asennikov
Copy link
Owner Author

asennikov commented Apr 25, 2016

@mansona Yeah, you're probably right. Let's do another PR, but let's just make it though it won't break apps that are already setting src directly there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants