-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ember 2.10+ compatibility #95
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
steveszc
commented
Apr 12, 2017
- updates ember/ember-cli to 2.12
- updates ember-try scenarios
- replaces jshint+ember-suave with eslint+eslint-plugin-ember-suave
- replaces ember-cli-blanket with ember-cli-code-coverage
- updates and cleans up dependencies
- adjusts test suite to run on ember >2.10
- jshint -> eslint - ember-suave -> eslint-plugin-ember-suave - ember-cli-test-loader - bower -> npm - ember-cli 2.6 -> 2.12 - update ember-cli-quint - update ember-load-initializers - update ember-sinon + ember-sinon-qunit
stick to Ember 2.9 from bower
Changes Unknown when pulling 27658ec on steveszc:fix-tests into ** on asennikov:master**. |
asennikov
approved these changes
Apr 13, 2017
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great - thank you!
globals: { | ||
'google': true | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh, finally - eslint!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.