Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combining --trim and --sheet-pack with --border-padding, --shape-padding and/or --inner-padding #1240

Closed
jameswilddev opened this issue Aug 30, 2016 · 4 comments

Comments

@jameswilddev
Copy link

Hello.

Is it possible to combine --trim and --sheet-pack with --border-padding, --shape-padding or --inner-padding when invoking the CLI?

I am testing with the following .ase:

player.zip

Using the following to try and pack frames as nearly as possible but have 1px between each border:

aseprite --batch --trim --sheet-pack --shape-padding 1 --border-padding 1 --sheet player.png player.ase

player

As seen, this has dropped the --border-padding and --shape-padding options; we get bleed in-engine around the edges.

Dropping only the --sheet-pack option re-enables padding, but as the sheet isn't well packed on many sprites we lose a lot of texture memory and on some platforms brush up against texture size limits.

aseprite --batch --trim --shape-padding 1 --border-padding 1 --sheet player.png player.ase

player

Is there a way to combine these behaviours, such as this?

player

Thank you.

@dacap dacap added the bug label Sep 5, 2016
@dacap
Copy link
Member

dacap commented Sep 6, 2016

@jameswilddev at this moment padding doesn't work when we pack the sheet. I'll see if I can do something about this issue.

@jobtalle
Copy link

I'm currently in dire need of this feature. If it's not in the pipeline, can someone point me towards the class where this should be implemented? If I find the time I can try to fix it & submit a pull request.

@Nuuf
Copy link

Nuuf commented Nov 27, 2018

I've written a little tool you can use in the meantime https://github.com/Nuuf/aseprite-packer
Basically you first export with aseprite and then if you need padding and/or border you can use this tool to add that. Has a CLI so you can combine the two.

Feel free to ask me any questions of you can't get it working.

@dacap
Copy link
Member

dacap commented Apr 1, 2019

Fixed by @kawa-yoiko with #2045

@dacap dacap closed this as completed Apr 1, 2019
@dacap dacap modified the milestones: v1.x-bugs, v1.2 Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants