Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increasing UI Elements Scaling causes ui to become more squished #2571

Closed
AaronRecord opened this issue Nov 28, 2020 · 1 comment · Fixed by #3942
Closed

Increasing UI Elements Scaling causes ui to become more squished #2571

AaronRecord opened this issue Nov 28, 2020 · 1 comment · Fixed by #3942
Assignees
Labels
Milestone

Comments

@AaronRecord
Copy link

I'm using a high dpi display (System scaling is 250% and resolution is 3200x1800).
Screen Scaling set to 400% and UI Elements Scaling set to 100%:
Screenshot 2020-11-27 205726
Screenshot 2020-11-27 205708
Screen Scaling set to 100% and UI Elements Scaling set to 400%:
Screenshot 2020-11-27 205945
Screenshot 2020-11-27 205643

Aseprite and System version

  • Aseprite version: 1.2.25, Steam
  • System: Windows 10
@dacap dacap added the bug label Nov 1, 2021
@dacap dacap added this to the v1.2.31 milestone Nov 1, 2021
@dacap dacap self-assigned this Nov 1, 2021
@dacap dacap assigned iamOgunyinka and unassigned dacap Dec 15, 2021
@Gasparoken Gasparoken added wip and removed wip labels Dec 23, 2021
@Gasparoken Gasparoken added the wip label Jan 10, 2022
@dacap dacap modified the milestones: v1.2.31, v1.2.32 Jan 12, 2022
@Gasparoken Gasparoken removed the wip label Jan 14, 2022
@Gasparoken Gasparoken added the wip label Jan 17, 2022
@iamOgunyinka
Copy link
Contributor

There are a few things worth mentioning here, so I would list them, in no particular order. The overall idea is that when you make and apply changes to the UI/Screen scaling from the preference/option window, all elements on the screen from the preference window itself to the menu (bar) down to the minutest element reflects the change (including resizing the window to make room or shrink to fit) without having to close and reopen windows.

Right now, this almost worked for everything except some menu items that become inconsistent (e.g. as shown below)

image

To solve menu bar(and items) problem, we could simply reload the menu bar and the main window seem to have no additional problem after this has been done. Then focus shifts to the option window exclusively now.

When UI scaling is adjusted, we reload the theme, apply/init the new theme to all the widgets and reset the screen. Invalidate()-ing the option window should ideally force a redraw of this opened window but unfortunately in this case, I tried it and it seem to be ignored. The texts of the list box that shows the sections are properly scaled and the list box size is adjusted to house the children (list box items). However, the parent view (or view port) of the listbox seem to be incorrectly calculating the size it needs to house the list box and thus result in cramping them in the littlest space(as shown in the image below). If this parent view port is removed, the items are correctly sized and adjusted.

Another noticeable problem is that all the texts in the option window's combo boxes (of all sections, not just the general section) are still in the previous UI scaling, not the new one. I traced this problem and followed all paths to ensure that really the theme is applied to all the items in the comboboxes and are available when a combo box is opened but I could not get to the root of this.

image

tl;dr the two things I could not get to the bottom of:

  1. scaling of list items in option window's combo boxes and
  2. getting the section listbox size right.

@Gasparoken Gasparoken removed the wip label Jan 18, 2022
@dacap dacap self-assigned this Feb 1, 2022
@dacap dacap added the ui label Feb 1, 2022
@dacap dacap modified the milestones: v1.2.33, v1.2.34 Feb 8, 2022
@dacap dacap modified the milestones: v1.2.34, v1.2.35 Mar 14, 2022
@dacap dacap modified the milestones: v1.2.35, v1.x-bugs Jun 1, 2022
@dacap dacap removed their assignment Sep 15, 2022
@martincapello martincapello self-assigned this Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants