New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix crash when saving tilemap's cel image #4089
Conversation
16bf6b5
to
dae68a1
Compare
Didn't review this, waiting for @Gasparoken, anyway it would be nice to add a note about any new sprite added in the |
I'll review this today. Sorry for the delay. |
54da35a
to
40f974b
Compare
Works great! I think the name |
Would |
LGTM!😊 |
I was testing and found that this solution saves an image with the size of the sprite (which could be different than the size of the image in the cel) and the image is placed at origin = 0.0. Therefore, it is necessary to shrink the image before saving, or define the correct size of the final image from the beginning. |
40f974b
to
b5cec7b
Compare
b5cec7b
to
c700709
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 🙌
After applying this PR:
Fix #4069